-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
2 changed files
with
31 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,16 @@ | ||
# Extraction of Salt core modules | ||
TODO - ref https://github.com/salt-extensions/extension_migration | ||
|
||
## Gotchas | ||
### Unit test imports | ||
|
||
Unit tests import the modules directly. After migration, these imports | ||
need to be adjusted, otherwise the tests will run against the modules found in Salt, but still pass (or fail once they are removed). Example: | ||
|
||
```python | ||
# Old import | ||
from salt.modules import vault | ||
|
||
# Correct | ||
from saltext.vault.modules import vault | ||
``` |