Add more maxPerfModeKeys and realated tests #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The coverage capture job is likely failing due to the access token being bound to this repo, not the fork. |
rwaldron
reviewed
Aug 28, 2024
| browser: ['Blob', 'crypto', 'Crypto', 'File', 'FileReader', 'SubtleCrypto', 'URL'], | ||
| browser: [ | ||
| 'Blob', | ||
| // 'createImageBitmap', |
There was a problem hiding this comment.
I left it there precisely to talk about it, this is a dev sync topic...
The TL;DR is that I if createImageBitmap is not remapped for maxPerfMode, we have to do the same for ImageData and this spirals into more and more changes. But our tests demonstrate that developers can use this API if we keep it remapped.
| 'File', | ||
| 'FileReader', | ||
| 'FileReaderSync', | ||
| // 'ImageData', |
rwaldron
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
W-16440739: Implement other MaxPerfMode tests based on W-16299351 inventory