Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grab ownership of task-bunny for Quantum #11

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

sturmer
Copy link
Member

@sturmer sturmer commented Dec 12, 2024

@sturmer sturmer requested review from anna-agafonova, mikktammeglia and a team December 12, 2024 11:52
@bautrey37
Copy link

bautrey37 commented Dec 12, 2024

If this owner is being assigned, because I contributed to this in 2021, then that doesn't make sense that Quantum is the owner. Back then, I was in Engage team, which then split into Messenger team. This is the original issue for my change .

@sturmer
Copy link
Member Author

sturmer commented Dec 12, 2024

If this owner is being assigned, because I contributed to this in 2021, then that doesn't make sense that Quantum is the owner. Back then, I was in Engage team, which then split into Messenger team. This is the original issue for my change .

Quantum team does use some RabbitMQ functionality, but I believe most of this is from Engagement-registry.

I don't know the criteria Anna used to propose this assignment, but it doesn't make sense to assign this to any team. I'm taking it just because this is not supposed to receive any change, and somebody needs to take it anyway, and personally I don't see why not us. I've added Mikk in the PR because if he wants to fight for this, he can. I don't mind either way.

@sturmer
Copy link
Member Author

sturmer commented Dec 12, 2024

!squash

@sm-deployer sm-deployer force-pushed the randomly-grab-code-ownership branch from 7f2ae8e to 0819556 Compare December 12, 2024 12:46
@sturmer
Copy link
Member Author

sturmer commented Dec 12, 2024

!merge

@sm-deployer sm-deployer force-pushed the randomly-grab-code-ownership branch from 0819556 to 3fc32c0 Compare December 12, 2024 12:47
@sturmer
Copy link
Member Author

sturmer commented Dec 12, 2024

!merge

@sturmer sturmer removed the merging label Dec 12, 2024
@sturmer sturmer merged commit 7678632 into master Dec 12, 2024
1 check passed
@sturmer sturmer deleted the randomly-grab-code-ownership branch December 12, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants