Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Elixir/Erlang and fix warnings #17

Merged
merged 8 commits into from
Jan 9, 2025
Merged

Bump Elixir/Erlang and fix warnings #17

merged 8 commits into from
Jan 9, 2025

Conversation

sviik
Copy link
Member

@sviik sviik commented Jan 7, 2025

No description provided.

@sviik
Bump ex_doc
8e4c73f 
Removes deprecation warnings.
@sviik sviik requested a review from indrekj January 8, 2025 07:30
indrekj
indrekj reviewed Jan 8, 2025
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
sviik added 6 commits January 9, 2025 09:38
@sviik
Log file metadata as a string
f1e1fe3 
After previous updates file metadata started appearing as a charlist
instead of string. This caused the logger treating it as a list, so
the output was a comma-separated list of integers. Fix by converting
`:file` metadata value to a string in case it's a char list.
@sviik
Run formatter
66d90a9 
It makes example test data less readable but there's no good way
around it.
@sviik
Change GH workflow name
901fd4b 
`Ruby` did not make sense.
@sviik
Bump actions/checkout to v4
088f807
@sviik
Bump version to 1.1.5
9e7695e
@sviik
Update version number in installation doc
13c2228 
The latest version has been 1.x for a while now.
@sviik
Copy link
Member Author

sviik commented Jan 9, 2025

@indrekj re-requesting review:

  1. Changed version number 9e7695e
  2. Added a fix for file metadata value f1e1fe3

Also, GH is waiting for a status from OTP 23.2 / Elixir 1.11 but it will never arrive as these versions are not in the test matrix anymore. Do you know if I should re-create a PR or is there something else that needs to be done?

@sviik sviik requested a review from indrekj January 9, 2025 07:43
@indrekj
Copy link
Member

indrekj commented Jan 9, 2025

I should re-create a PR or is there something else that needs to be done

Somebody with admin permissions could remove that requirement, I myself don't have permissions for this repo though

@sviik sviik merged commit f9adb08 into master Jan 9, 2025
6 checks passed
@sviik sviik deleted the bump-elixir branch January 9, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indrekj indrekj indrekj approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sviik @indrekj