Automatically publish package on version bump #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the package needed to be manually published by somebody with permissions. This is a hasstle if the changes were authored by somebody without permissions. A Github Action will automatically publish a new version and add a tag when changes are merged to master that increase the version number in gemspec. If the version in unchanged when changes are merged then the action fails but does so silently. CHAN-1774
|
Ostap added the |
ostap0207
approved these changes
Oct 6, 2021
urmastalimaa
reviewed
Oct 6, 2021
|
|
||
|
|
||
| - name: Release Gem | ||
| uses: discourse/publish-rubygems-action@b55d7b91b55e61752dc6cbc2972f8e16fe6c1a02 |
There was a problem hiding this comment.
There is also https://github.com/salemove/publish-rubygems-action, I don't quite know for what reason it was created, but perhaps of security considerations. In any case, running 3rd party actions should be vetted by the inf team.
There was a problem hiding this comment.
I forked that myself at some point, but at the end of the day the consensus seemed to be that pinning the action to a commit hash would be secure enough.
There was a problem hiding this comment.
I'll just archive it.
urmastalimaa
approved these changes
Oct 6, 2021
|
!merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the package needed to be manually published by somebody with
permissions. This is a hasstle if the changes were authored by somebody without
permissions. A Github Action will automatically publish a new version and add a
tag when changes are merged to master that increase the version number in
gemspec. If the version in unchanged when changes are merged then the action
fails but does so silently.
See this PR for related discussion.
CHAN-1774