Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAK-50557 LTI exceptions thrown for some tools placed in users workspace #12941

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SAK-50557 LTI exceptions thrown for some tools placed in users workspace #12941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...ti/basiclti-impl/src/java/org/sakaiproject/basiclti/impl/BasicLTISecurityServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,9 @@ private void redirectOIDC(HttpServletRequest req, HttpServletResponse res,

byte[] bytesEncoded = Base64.encodeBase64(login_hint.getBytes());
String encoded_login_hint = new String(bytesEncoded);

log.debug("login_hint=[{}], encoded_login_hint=[{}]", login_hint, encoded_login_hint);

try {
URIBuilder redirect = new URIBuilder(oidc_endpoint.trim());
redirect.addParameter("iss", SakaiBLTIUtil.getOurServerUrl());
Expand Down
3 changes: 3 additions & 0 deletions basiclti/basiclti-oidc/src/java/org/sakaiproject/lti13/OIDCServlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,12 +126,15 @@ private void handleOIDCAuthorization(HttpServletRequest request, HttpServletResp
redirect_uri = StringUtils.trimToNull(redirect_uri);

String encoded_login_hint = (String) request.getParameter("login_hint");
encoded_login_hint = encoded_login_hint.replace(' ', '+'); // when posted, plus signs may become supplanted by spaces
byte[] valueDecoded = Base64.decodeBase64(encoded_login_hint);
String login_hint = new String(valueDecoded);
if (StringUtils.isEmpty(login_hint)) {
state = null;
}

log.debug("login_hint=[{}], encoded_login_hint=[{}]", login_hint, encoded_login_hint);

String nonce = (String) request.getParameter("nonce");
nonce = StringUtils.trimToNull(nonce);

Expand Down
4 changes: 4 additions & 0 deletions library/src/skins/default/src/sass/modules/tool/portal/_portal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,3 +577,7 @@
color: var(--sakai-text-color-1);
background-color: var(--sakai-background-color-2);
}

i.fa {
width: 14px;
}
Loading