Add basic support for .heic files #519
Conversation
src/sigal/image.py
Outdated
| if hasattr(img, "_getexif") and callable(img._getexif): | ||
| exif = img._getexif() | ||
| elif "exif" in img.info: | ||
| exif = img.getexif()._get_merged_dict() |
There was a problem hiding this comment.
img._getexif() is an alias for img.getexif()._get_merged_dict() so we can probably switch to the public methods, which I think are supported since a long time ? (Our min version of pillow is 8.0 currently)
There was a problem hiding this comment.
Gladly!
I just wasn't sure if I would break any weird combination, because both variants use some private API.
But let tox find out :-)
src/sigal/gallery.py
Outdated
| @@ -264,7 +264,7 @@ def exif(self): | |||
| datetime_format = self.settings["datetime_format"] | |||
| return ( | |||
| get_exif_tags(self.raw_exif, datetime_format=datetime_format) | |||
| if self.raw_exif and self.src_ext in (".jpg", ".jpeg") | |||
| if self.raw_exif and self.src_ext in (".jpg", ".jpeg", ".heic") | |||
There was a problem hiding this comment.
The extension list here and below should also include ".heif" I guess ?
Also, those extensions should be recognized only if pillow-heif is available, so might be better to store this list somewhere where it can be imported (in the image module ?) and reused.
There was a problem hiding this comment.
I'm not sure about .heif files. As I understand it, this is more of a container format and may contain different image-formats.
I guess pillow-heif should be able to handle them all, but I have no way to test that yet.
I would actually prefer it if the program errors out if it encounters .heic images without pillow-heif installed, instead of just silently ignoring and skipping those pictures.
I mean, they are in fact Images - no matter if supported or not - and the user probably intended for them to be included in the gallery.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
==========================================
- Coverage 90.72% 90.57% -0.15%
==========================================
Files 24 24
Lines 2026 2037 +11
==========================================
+ Hits 1838 1845 +7
- Misses 188 192 +4 ☔ View full report in Codecov by Sentry. |
|
@ususdei - I played a bit with the code and activated .heic extensions by default so sigal finds them and logs a warning if pillow-heif is missing. Is it ok for you ? And just to be sure, test image is one of yours that you accept to share under sigal's license ? |
|
@saimn Yeah, sure! I'm totally okay with that. And thanks for the cleanup. I took that random picture specifically for that purpose. |
|
Great, thanks a lot ! |
No description provided.