Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.48.2 #4724

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Release 1.48.2 #4724

merged 4 commits into from
Jan 6, 2025

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Jan 3, 2025

@katspaugh katspaugh changed the base branch from dev to main January 3, 2025 06:33
Copy link

github-actions bot commented Jan 3, 2025

Copy link

github-actions bot commented Jan 3, 2025

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1016.42 KB (🟡 +3.8 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Forty Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/_offline 1.09 KB (🟢 -9 B) 1017.51 KB
/addOwner 555 B (🟢 -9 B) 1016.96 KB
/address-book 23.08 KB (🟡 +7 B) 1.02 MB
/apps 33.25 KB (🟢 -492 B) 1.03 MB
/apps/bookmarked 464 B (🟢 -11 B) 1016.88 KB
/apps/custom 31.3 KB (🟢 -493 B) 1.02 MB
/apps/open 53.64 KB (🟡 +26 B) 1.04 MB
/balances 29.81 KB (🟡 +102 B) 1.02 MB
/balances/nfts 9.64 KB (🟡 +96 B) 1 MB
/bridge 2.54 KB (🟢 -12 B) 1018.97 KB
/cookie 8.75 KB (🟢 -27 B) 1 MB
/home 58.7 KB (🟢 -571 B) 1.05 MB
/imprint 1.39 KB (🟢 -25 B) 1017.81 KB
/licenses 2.44 KB (🟢 -24 B) 1018.86 KB
/new-safe/advanced-create 26.43 KB (🟢 -19 B) 1.02 MB
/new-safe/create 25.57 KB (🟢 -24 B) 1.02 MB
/new-safe/load 6.06 KB (🟢 -32 B) 1022.48 KB
/privacy 14.54 KB (🟢 -29 B) 1.01 MB
/settings 466 B (🟢 -9 B) 1016.88 KB
/settings/appearance 2.33 KB (🟡 +80 B) 1018.75 KB
/settings/cookies 1.96 KB (🟡 +84 B) 1018.38 KB
/settings/data 1.88 KB (🟡 +89 B) 1018.3 KB
/settings/environment-variables 3.36 KB (🟡 +86 B) 1019.78 KB
/settings/modules 4.12 KB (🟡 +70 B) 1020.55 KB
/settings/notifications 21.38 KB (🟡 +71 B) 1.01 MB
/settings/safe-apps 17.82 KB (🟢 -467 B) 1.01 MB
/settings/security 2.42 KB (🟡 +81 B) 1018.84 KB
/settings/setup 30.81 KB (🟡 +75 B) 1.02 MB
/share/safe-app 7.56 KB (🟢 -3 B) 1023.98 KB
/stake 609 B (🟢 -10 B) 1017.02 KB
/swap 749 B (🟢 -11 B) 1017.15 KB
/terms 12.91 KB (🟢 -23 B) 1.01 MB
/transactions 96.88 KB (🟡 +309 B) 1.09 MB
/transactions/history 96.84 KB (🟡 +309 B) 1.09 MB
/transactions/messages 58.4 KB (🟡 +99 B) 1.05 MB
/transactions/msg 54.55 KB (🟡 +2 B) 1.05 MB
/transactions/queue 47.51 KB (🟡 +117 B) 1.04 MB
/transactions/tx 46.78 KB (🟡 +16 B) 1.04 MB
/welcome 6.91 KB (🟢 -17 B) 1023.34 KB
/welcome/accounts 399 B (🟢 -8 B) 1016.81 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Jan 3, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.93% (+0.01% 🔼)
14409/19491
🔴 Branches
51.46% (+0.01% 🔼)
3437/6679
🔴 Functions 56.88% 2046/3597
🟡 Lines
75.46% (+0.01% 🔼)
13069/17319
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / SignForm.tsx
91.8% (-0.13% 🔻)
84.85% (-0.45% 🔻)
100%
92.98% (-0.12% 🔻)
🟡
... / useTransactionType.tsx
64.71% (+1.96% 🔼)
34.04% (-0.65% 🔻)
100%
65.31% (+2.04% 🔼)

Test suite run success

1713 tests passing in 233 suites.

Report generated by 🧪jest coverage report action from 6b432b0

@liliya-soroka
Copy link
Member

Verified

@katspaugh katspaugh merged commit 6b432b0 into main Jan 6, 2025
15 checks passed
@katspaugh katspaugh deleted the release branch January 6, 2025 07:05
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants