Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: Safe bundles #4710

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

POC: Safe bundles #4710

wants to merge 5 commits into from

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Dec 27, 2024

DO NOT MERGE

Copy link

github-actions bot commented Dec 27, 2024

Copy link

github-actions bot commented Dec 27, 2024

📦 Next.js Bundle Analysis for @safe-global/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1 MB (🟡 +15.44 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load
/bundle 223.72 KB 1.22 MB
/welcome/bundles 2.58 KB 1.01 MB

Thirty-two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 508 B (🟢 -2 B) 1 MB
/address-book 23.07 KB (🟡 +4 B) 1.03 MB
/apps 35.8 KB (🟡 +2.08 KB) 1.04 MB
/apps/custom 33.87 KB (🟡 +2.08 KB) 1.04 MB
/apps/open 55.57 KB (🟡 +1.96 KB) 1.06 MB
/balances 29.74 KB (🟡 +38 B) 1.03 MB
/balances/nfts 9.52 KB (🟢 -24 B) 1.01 MB
/bridge 2.56 KB (🟡 +1 B) 1.01 MB
/cookie 8.77 KB (🟡 +1 B) 1.01 MB
/home 61.38 KB (🟡 +2.12 KB) 1.06 MB
/new-safe/advanced-create 26.39 KB (🟢 -68 B) 1.03 MB
/new-safe/create 25.52 KB (🟢 -67 B) 1.03 MB
/new-safe/load 6.08 KB (🟢 -3 B) 1.01 MB
/privacy 14.57 KB (🟡 +2 B) 1.02 MB
/settings/appearance 2.25 KB (🟡 +2 B) 1.01 MB
/settings/environment-variables 3.27 KB (🟢 -1 B) 1.01 MB
/settings/modules 4.06 KB (🟡 +1 B) 1.01 MB
/settings/notifications 21 KB (🟢 -324 B) 1.02 MB
/settings/safe-apps 20.35 KB (🟡 +2.08 KB) 1.02 MB
/settings/security 2.34 KB (🟡 +1 B) 1.01 MB
/settings/setup 30.69 KB (🟢 -42 B) 1.03 MB
/share/safe-app 7.56 KB (🟢 -5 B) 1.01 MB
/stake 618 B (🟢 -1 B) 1 MB
/swap 759 B (🟢 -1 B) 1 MB
/terms 12.93 KB (🟡 +1 B) 1.02 MB
/transactions 98.65 KB (🟡 +2.08 KB) 1.1 MB
/transactions/history 98.61 KB (🟡 +2.08 KB) 1.1 MB
/transactions/messages 60.26 KB (🟡 +1.96 KB) 1.06 MB
/transactions/msg 56.51 KB (🟡 +1.96 KB) 1.06 MB
/transactions/queue 49.37 KB (🟡 +1.97 KB) 1.05 MB
/transactions/tx 48.73 KB (🟡 +1.96 KB) 1.05 MB
/welcome/accounts 408 B (🟡 +1 B) 1 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Dec 27, 2024

Coverage report for apps/web

St.
Category Percentage Covered / Total
🟡 Statements
74.08% (-0.02% 🔻)
14582/19683
🔴 Branches 51.72% 3479/6727
🔴 Functions
57.05% (-0.06% 🔻)
2064/3618
🟡 Lines
75.63% (-0.02% 🔻)
13227/17488
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / bundleSlice.ts
40% 100% 0% 45.45%

Test suite run success

1758 tests passing in 238 suites.

Report generated by 🧪jest coverage report action from 93e007b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant