fix: always estimate relay gasLimit
#4679
Conversation
Branch preview✅ Deploy successful! Storybook: |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1016.57 KB (🟡 +91 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Two Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/new-safe/advanced-create |
26.43 KB (🟡 +1 B) |
1.02 MB |
/new-safe/create |
25.57 KB (🟡 +1 B) |
1.02 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Show new covered files 🐣
Test suite run success1715 tests passing in 233 suites. Report generated by 🧪jest coverage report action from ffc3feb |
|
Verified |
What it solves
Resolves inconsistent relays on Arbitrum
How this PR fixes it
When relaying, a
gasLimitcan be optionally provided in the request. If provided, a 150k buffer is added to it for the Gelato execution overhead. If none is provided, Gelato estimates this on our behalf and no buffer is added.This explicitly provides the
gasLimitto relay requests (if present), otherwise manually estimates it if none is provided.How to test it
Ensure relay attempts do not fail (particularly on Arbitrum) for the following cases, and that the
gasLimitis present in eachPOSTrequest to the/v1/chains/:chainId/relay:Checklist