refactor: switch to a monorepo structure WIP #4638
Conversation
Branch preview⏳ Deploying a preview site... |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
.github/workflows/yarn/action.yml
Outdated
| @@ -14,7 +17,7 @@ runs: | |||
| key: web-core-modules-${{ hashFiles('**/yarn.lock') }} | |||
| - name: Yarn install | |||
| shell: bash | |||
| run: yarn install --frozen-lockfile | |||
| run: yarn install --immutable | |||
| - name: Yarn after install | |||
| shell: bash | |||
| run: yarn after-install | |||
There was a problem hiding this comment.
-
Replace
yarn install --immutablewithyarn install --frozen-lockfilefor clarity and consistency, as--immutableis less commonly used and may confuse users familiar with the standard flag. -
Ensure corepack is available on all execution environments, or check if an additional verification step is needed to validate installation success.
.gitignore
Outdated
| @@ -56,3 +56,4 @@ yalc.lock | |||
| /public/*.js.LICENSE.txt | |||
| certificates | |||
| *storybook.log | |||
| /.yarn | |||
There was a problem hiding this comment.
Adding /.yarn to .gitignore may lead to unintended consequences if using Yarn Plug'n'Play. If the inclusion is deliberate, ensure dependencies are correctly managed; if not, reconsider to avoid missing critical files in the repository.
|
|
||
| enableGlobalCache: false | ||
|
|
||
| nodeLinker: node-modules |
There was a problem hiding this comment.
- "compressionLevel: mixed" - Consider providing clear values or documentation, as "mixed" may be ambiguous. Ensure it meets application logic requirements.
- "nodeLinker: node-modules" - Verify compatibility with other settings or systems.
| @@ -168,5 +162,6 @@ | |||
| "budgetPercentIncreaseRed": 20, | |||
| "minimumChangeThreshold": 0, | |||
| "showDetails": true | |||
| } | |||
| }, | |||
| "packageManager": "[email protected]" | |||
| } | |||
There was a problem hiding this comment.
Check the removal of the "resolutions" block. If multiple versions of the "ethers" package are used and need to be unified across dependencies, removing resolutions could introduce compatibility issues. Ensure compatibility is checked post-removal.
.github/workflows/yarn/action.yml
Outdated
| # We require yarn v4 and installing through corepack is the easiest way to get it | ||
| - name: Enable Corepack | ||
| shell: bash | ||
| run: corepack enable |
There was a problem hiding this comment.
Ensure the shell: bash addition is appropriate for the environment you're targeting. If the script will run in a non-bash environment, this explicit shell definition might cause issues.
| "@safe-global/api-kit/ethers": "6.11.1", | ||
| "@gnosis.pm/zodiac/ethers": "6.11.1", | ||
| "@keystonehq/eth-keyring": "0.14.4" | ||
| }, | ||
| "engines": { | ||
| "node": ">=18" | ||
| }, |
There was a problem hiding this comment.
Ensure compatibility of the overridden package versions with the rest of the dependencies. Conflicting versions can lead to unexpected behavior or runtime errors. If possible, check for any peer dependencies or breaking changes associated with these overrides.
Coverage report
Test suite run success1712 tests passing in 232 suites. Report generated by 🧪jest coverage report action from 5a4ac73 |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Eleven Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
compojoom
force-pushed
the
monorepo
branch
6 times, most recently
from
05b28a0 to
5872f08
Compare
fix: github action crashing . fix: failing yarn v4 install due to incorrect 3rd party dependency fix: remove Keystone pckg causing yarn v4 failure fix: resolve merge conflict fix: resolutions fix: failing tests
What it solves
Resolves #
How this PR fixes it
How to test it
Screenshots
Checklist