Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pending recoveries in dashboard widget #2851

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

iamacook
Copy link
Member

What it solves

Resolves #2755

How this PR fixes it

Pending recovery attempts are now listed in the pending transaction dashboard widget.

How to test it

Ensuring recovery is enabled, queue a recovery attempt (as well as a standard transaction) and observe the both in the pending transaction list widget on the dashboard

Screenshots

image

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from katspaugh November 22, 2023 19:40
@iamacook iamacook linked an issue Nov 22, 2023 that may be closed by this pull request
2 tasks
Copy link

github-actions bot commented Nov 22, 2023

Branch preview

✅ Deploy successful!

https://recovery_pending_tx_widget--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 22, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 22, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.3% (-0.05% 🔻)
10730/14249
🔴 Branches
50.05% (-0.19% 🔻)
2175/4346
🔴 Functions
57.89% (-0.22% 🔻)
1603/2769
🟡 Lines
76.79% (-0.06% 🔻)
9724/12663
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟡
... / PendingTxsList.tsx
61.7% 33.33% 27.27% 64.44%
🟡
... / PendingTxListItem.tsx
65.38% 0% 0% 68%
🟡
... / PendingRecoveryListItem.tsx
64.29% 100% 0% 64.29%
🟡
... / index.tsx
50% 0% 0% 60%
🟢
... / index.tsx
66.67% 0% 0% 80%
🟡
... / index.tsx
60% 0% 0% 60%

Test suite run success

1216 tests passing in 172 suites.

Report generated by 🧪jest coverage report action from 48a37f4

@iamacook iamacook merged commit c46fcbb into recovery-epic Nov 23, 2023
6 of 11 checks passed
@iamacook iamacook deleted the recovery-pending-tx-widget branch November 23, 2023 08:20
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Recovery] Add recovery attempts to pending transactions widget
2 participants