Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update API Kit guide signing flow #465

Merged
merged 3 commits into from
May 8, 2024
Merged

Conversation

germartinez
Copy link
Member

Context

This PR fixes:

  • Fixes API Kit guide variables and signing flow
  • Removes dotenv from Protocol Kit

@germartinez germartinez requested a review from yagopv May 7, 2024 15:43
Copy link

github-actions bot commented May 7, 2024

Overall readability score: 56.16 (🔴 -0.07)

File Readability
api-kit.mdx 54.35 (🔴 -4.57)
protocol-kit.mdx 67.38 (🔴 -0.87)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
api-kit.mdx 54.35 43.32 11.87 12.8 11.89 7.4
  🔴 -4.57 🔴 -2.24 🔴 -0.91 🔴 -1.2 🔴 -0.41 🔴 -0.1
protocol-kit.mdx 67.38 56.96 9.36 10.1 11.36 6.84
  🔴 -0.87 🔴 -0.31 🔴 -0.11 🔴 -0.2 🔴 -0.17 🔴 -0.03

Averages:

  Readability FRE GF ARI CLI DCRS
Average 56.16 48.97 10.78 12.64 12.35 7.58
  🔴 -0.07 🔴 -0.03 🔴 -0.01 🔴 -0.02 🔴 -0.01 🟢 +0
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

pages/sdk/api-kit.mdx Outdated Show resolved Hide resolved
@germartinez germartinez merged commit 24adb97 into development May 8, 2024
2 checks passed
@germartinez germartinez deleted the api-kit-guide branch May 8, 2024 10:00
@germartinez germartinez mentioned this pull request May 10, 2024
germartinez added a commit that referenced this pull request May 22, 2024
* Fix API Kit guide

* Fix Protocol Kit guide

* Fix API Kit guide with the proper private key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants