Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: options added in executeRelayTransaction #559

Closed
wants to merge 1 commit into from

Conversation

donoso-eth
Copy link

What it solves

spondoredCalls are not routed properly

In the [email protected] when calling

    const response = await this.#relayPack.executeRelayTransaction(
      signedSafeTransaction,
      this.#safeSdk
    )

the options are not passed so that the relay-kit will route all calls through this.sendSyncTransaction(target, encodedTransaction, chainId, options)

How this PR fixes it

Adding the options to the executeRelayTransaction call

    const response = await this.#relayPack.executeRelayTransaction(
      signedSafeTransaction,
      this.#safeSdk,
      options
    )

@github-actions
Copy link

github-actions bot commented Oct 22, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@donoso-eth
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@dasanra dasanra changed the base branch from main to development October 24, 2023 08:51
@dasanra
Copy link
Collaborator

dasanra commented Oct 31, 2023

@donoso-eth thank you for your PR! We fixed it in #571 adding some test cases to the package.

@dasanra dasanra closed this Oct 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants