Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mdx): switch to official next-mdx-remote v5 #1217

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sabertazimi
Copy link
Owner

Pull Request

This PR Contains

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Test-Case

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Breaking Changes

Additional Info

This PR has 613 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +26 -587
Percentile : 87.1%

Total files changed: 6

Change summary by file extension:
.tsx : +1 -1
.ts : +2 -2
.js : +0 -1
.json : +1 -5
.yaml : +22 -578

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 3:18am

Copy link
Contributor

github-actions bot commented Mar 14, 2024

Lighthouse Report

https://blog-6dp15nyfa-sabertazs-projects.vercel.app/

🚀 Vercel preview deployment
Lighthouse report

Category Score
🟢 performance 93
🟢 accessibility 100
🟡 best-practices 78
🟢 seo 100
🟢 pwa 100

https://blog-6dp15nyfa-sabertazs-projects.vercel.app/posts

🚀 Vercel preview deployment
Lighthouse report

Category Score
🟢 performance 97
🟢 accessibility 94
🟡 best-practices 74
🟢 seo 100
🟢 pwa 100

https://blog-6dp15nyfa-sabertazs-projects.vercel.app/tags

🚀 Vercel preview deployment
Lighthouse report

Category Score
🟢 performance 99
🟢 accessibility 94
🟡 best-practices 74
🟢 seo 100
🟢 pwa 100

https://blog-6dp15nyfa-sabertazs-projects.vercel.app/books

🚀 Vercel preview deployment
Lighthouse report

Category Score
🟢 performance 98
🟢 accessibility 94
🟡 best-practices 74
🟢 seo 100
🟢 pwa 100

https://blog-6dp15nyfa-sabertazs-projects.vercel.app/about

🚀 Vercel preview deployment
Lighthouse report

Category Score
🟢 performance 97
🟢 accessibility 94
🟡 best-practices 74
🟢 seo 100
🟢 pwa 100

Copy link

socket-security bot commented Mar 14, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment, filesystem, shell, unsafe Transitive: eval, network +68 12.6 MB atofstryker
npm/[email protected] unsafe Transitive: environment, filesystem +48 10.5 MB vercel-release-bot
npm/[email protected] environment, filesystem Transitive: eval, shell +51 8.41 MB eslintbot
npm/[email protected] environment 0 2.24 MB popmotion
npm/[email protected] eval, filesystem +1 443 kB rmassaioli
npm/[email protected] Transitive: environment, eval +7 3.3 MB nickcolley
npm/[email protected] Transitive: eval, filesystem, network, shell, unsafe +8 3.34 MB simenb
npm/[email protected] None 0 5.01 kB simenb
npm/[email protected] Transitive: filesystem, shell +1 4.07 MB ylemkimon
npm/[email protected] environment +9 225 kB hashibot-web
npm/[email protected] None 0 75.5 kB skyleen
npm/[email protected] filesystem +5 242 kB shadowwalker1117
npm/[email protected] Transitive: filesystem +4 512 kB iamvishnusankar
npm/[email protected] environment, filesystem, network, shell, unsafe +1 86.2 MB vercel-release-bot
npm/[email protected] None 0 5.44 kB euank
npm/[email protected] None 0 8.43 kB luisrudge
npm/[email protected] None 0 91.2 kB romainmenke
npm/[email protected] environment, filesystem +1 203 kB ai
npm/[email protected] None 0 2.57 MB thecrypticace
npm/[email protected] environment, filesystem, unsafe 0 8.39 MB prettier-bot
npm/[email protected] None 0 371 kB gksander
npm/[email protected] environment 0 4.51 MB react-bot
npm/[email protected] None 0 85.4 kB nihgwu
npm/[email protected] environment +5 800 kB streamich
npm/[email protected] environment 0 318 kB react-bot
npm/[email protected] None 0 10.2 kB ngryman
npm/[email protected] None 0 30 kB wooorm
npm/[email protected] None 0 23.3 kB wooorm
npm/[email protected] None 0 15.7 kB wooorm
npm/[email protected] None 0 19.2 kB remcohaszing
npm/[email protected] None 0 11.5 kB wooorm
npm/[email protected] None 0 18.6 kB wooorm
npm/[email protected] None 0 11.9 kB wooorm
npm/[email protected] None 0 21.4 kB wooorm
npm/[email protected] None 0 38.6 kB wooorm
npm/[email protected] None 0 12.9 kB wooorm
npm/[email protected] environment Transitive: eval, filesystem, shell, unsafe +10 891 kB bahmutov
npm/[email protected] environment Transitive: filesystem +39 2.75 MB ybiquitous
npm/[email protected] environment, filesystem +7 5.82 MB adamwathan
npm/[email protected] environment, filesystem, unsafe +2 420 kB kul
npm/[email protected] None 0 84 kB typescript-bot
npm/[email protected] None 0 154 kB mattboldt
npm/[email protected] None 0 32.4 MB typescript-bot
npm/[email protected] None 0 28.5 kB wooorm

View full report↗︎

This PR has 613 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +26 -587
Percentile : 87.1%

Total files changed: 6

Change summary by file extension:
.tsx : +1 -1
.ts : +2 -2
.js : +0 -1
.json : +1 -5
.yaml : +22 -578

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Telemetry npm/[email protected]
  • Note: Can be disabled by setting the environment variable NEXT_TELEMETRY_DISABLED=1 . See https://nextjs.org/telemetry for more information
Install scripts npm/[email protected]
  • Install script: postinstall
  • Source: node index.js --exec install

View full report↗︎

Next steps

What is telemetry?

This package contains telemetry which tracks how it is used.

Most telemetry comes with settings to disable it. Consider disabling telemetry if you do not want to be tracked.

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant