Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Veracode Batch Fix #27

Open
wants to merge 2 commits into
base: sa-ny-patch-15
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions application/views/resetController.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def reset(request):
elif(request.method == "POST"):
return processReset(request)
else:
h = httplib2.Http(".cache", disable_ssl_certificate_validation=True) #CWE-295
h = httplib2.Http(".cache", verify_ssl=True) #CWE-295
h.add_credentials('thiswaskevinsidea','hardcode') #CWE-798
data=h.request("http://localhost/",method='GET')
return data
Expand Down Expand Up @@ -109,6 +109,7 @@ def processReset(request):
for blabber in users[2:]:
for listener in users[2:]:
if rand.choice([False, True]) and (blabber != listener):
rand = random.SystemRandom()


logger.info("Adding " + listener.username + " as a listener of " + blabber.username)
Expand All @@ -125,7 +126,8 @@ def processReset(request):
blabsStatement = "INSERT INTO blabs (blabber, content, timestamp) values (%s, %s, datetime('now'));"
for blabContent in blabsContent:
# Get the array offset for a random user
randomUserOffset = rand.randint(2,len(users) - 1)
rand = random.SystemRandom()
randomUserOffset = rand.randint(2, len(users) - 1)

# get the number or seconds until some time in the last 30 days.
#vary = rand.randint(0,(30 * 24 * 3600)+1)
Expand All @@ -144,19 +146,20 @@ def processReset(request):
commentsStatement = "INSERT INTO comments (blabid, blabber, content, timestamp) values (%s, %s, %s, datetime('now'));"
for i in range(len(blabsContent)):
# Add a random number of comment
count = rand.randint(0,5) # between 0 and 6
rand = random.SystemRandom()
count = rand.randint(0, 5) # between 0 and 6

for j in range(count) :
# Get the array offset for a random user
randomUserOffset = rand.randint(2,len(users)-1) #removed +1 cause no admin, removed -2 because no admin and inclusive.
randomUserOffset = rand.SystemRandom().randint(2, len(users)-1) #removed +1 cause no admin, removed -2 because no admin and inclusive.
username = users[randomUserOffset].username

# Pick a random comment to add
commentNum = rand.randint(0,len(commentsContent)-1)
commentNum = rand.SystemRandom().randint(0, len(commentsContent)-1)
comment = commentsContent[commentNum]

# get the number or seconds until some time in the last 30 days.
vary = rand.randint(0,(30 * 24 * 3600)+1)
vary = rand.SystemRandom().randint(0, (30 * 24 * 3600)+1)

logger.info("Adding a comment from " + username + " on blab ID " + str(i))

Expand Down