Pin composed actions to their current releases' SHA #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekjaranowski
approved these changes
May 17, 2024
slawekjaranowski
force-pushed
the
brrygrdn/pin-composed-actions-versions-by-sha
branch
from
db85a9d
to
e2f38a4
Compare
robot-simplify4u
approved these changes
May 17, 2024
|
|
|
@daniel-beck hmm, no, I think that was purely oversight on my part |
|
setup-java done in #93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for all your work maintaining this action, I'm hoping to use it for a project and had one minor suggestion about how the composed Actions are maintained.
A best practice we've been adopting in workflows and composite actions is to prefer to use the commit SHA of each release tag to avoid any scenarios where the tag is reassigned to a different commit after we've verified the downstream changes and upgraded.
This is fairly manageable on a mechanical level because Dependabot is smart enough to detect and maintain this practice, which I verified on my fork by deliberately downgrading and double-checking it upgraded maintaining the pinned SHA notation.
I realise that this will have a potential increase in the frequency upgrade PRs will be opened as this is moving from a major-version pin to a patch-version pin for three of the dependencies, so I'm curious if this is something you find beneficial or not?