-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: major cleanup #6
Conversation
Signed-off-by: Mateusz Urbanek <[email protected]>
Signed-off-by: Mateusz Urbanek <[email protected]>
Signed-off-by: Mateusz Urbanek <[email protected]>
Signed-off-by: Mateusz Urbanek <[email protected]>
I hope I didn't broke any CI, but I tried to maintain all defaults and behaviour of both the driver and Makefile. |
Signed-off-by: Mateusz Urbanek <[email protected]>
Hi @shanduur - thank you for the submission! I'll review it in the coming days, if not earlier. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a typo in the Dockerfile, and a few non-blocking nits, this looks absolutely amazing work.
Thank you so much for all the effort you put into it, and sincere apologies for the delay in reviewing. :)
Signed-off-by: Mateusz Urbanek <[email protected]>
@shanduur lint failed for some reason - mind checking whether this looks like it's coming from your changes? Let me know if not and I'll try figuring it out. |
d201c86
to
3f14df1
Compare
Signed-off-by: Mateusz Urbanek <[email protected]>
3f14df1
to
ec9442f
Compare
@shanduur merged - thank you for your patience and effort! :) |
Describe your changes
Based on the commit messages provided, here is a description of the changes made:
Reworking Dockerfile to use multistage build:
Cleanup and update tooling:
Reducing dependencies and cleaning up code:
Extending documentation for servers:
Standardizing labels on container:
org.opencontainers.image.*
standard.Issue ticket number and link
N/A
Checklist before requesting a review