ci: run go vet and staticcheck separately #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominickh, the author of staticcheck, doesn't recommend running staticcheck as a part of golangci-lint. Run the real, official staticcheck separately. Run go vet separately as well. This way we know we're using the latest official go vet tool. Also, use autobuild to set up Go in the CodeQL analysis workflow.
ryboe
force-pushed
the
rb/ci_improvements
branch
from
de70bfe
to
a18258f
Compare
ryboe
force-pushed
the
rb/ci_improvements
branch
from
9cecbbd
to
11db3b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dominickh, the author ofstaticcheck, doesn't recommend running staticcheck as a part of golangci-lint. Run the real, officialstaticcheckseparately.go vetseparately as well. This way we know we're using the latest officialgo vettoolautobuildto set up Go in the CodeQL analysis workflowTestExtractingArgsFromSourceTextto avoid use of deprecatedast.ObjecttypeWillAbides/setup-go-fasterinstead ofactions/setup-gobecause it's faster