Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove restrictions on valid clamped numbers #211

Merged
merged 1 commit into from
May 28, 2024
Merged

Remove restrictions on valid clamped numbers #211

merged 1 commit into from
May 28, 2024

Conversation

vrugtehagel
Copy link
Contributor

@vrugtehagel vrugtehagel commented May 26, 2024 •
edited
Loading

Removes restrictions on clamped (but valid) numbers, such as opacity: 2; or rgba(567 567 567). This resolves #210.

argyleink
argyleink approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@argyleink argyleink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree with your take here. being closer to the spec and less of a linter is healthy for both this syntax highlighter and linters

@argyleink argyleink merged commit d1b7cdc into ryboe:master May 28, 2024
1 check passed
@vrugtehagel vrugtehagel deleted the vrugtehagel/remove-restrictions-on-valid-clamped-numbers branch May 28, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argyleink argyleink argyleink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow unclamped values where the spec allows it
2 participants
@vrugtehagel @argyleink