Add view-transition psuedo elements and property #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argyleink
requested changes
May 28, 2024
There was a problem hiding this comment.
rad work here, thanks a bunch
however, there is one newer view transition property that could be added: view-transition-class. would you kindly add that and then we'll get this all merged in 👍🏻
|
Whoops! Missed that one, it's been added. Thanks! |
vrugtehagel
deleted the
vrugtehagel/add-view-transition-psuedo-elements-and-property
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds all the view-transition stuff.
Optionally, we can choose to highlight the
rootkeyword differently from other idents, but I chose not to just to align with e.g.:dir()(which only accepts keywords).Resolves #199.