Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

call onLoad given as Props #220

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

call onLoad given as Props #220

wants to merge 3 commits into from

Conversation

yukukotani
Copy link

Currently onLoad is overridden by handleLoad so does not works.

@ryanseddon
Copy link
Owner

We might need to rejig this once #207 merges as the logic moves away from onLoad to utilising DOMContentLoaded instead

@yukukotani
Copy link
Author

yukukotani commented Aug 19, 2022 •
edited
Loading

@ryanseddon oh I didn't notice that.

Or maybe we don't need this. We manually subscribe load event by addEventListener so it seems there is no reason to give onLoad props of iframe. Can we just remove onLoad props at line 139?

@yukukotani
Copy link
Author

@ryanseddon
Sorry please forget the comment above, i misunderstood the logic.

I've added the commit 85b924e so that this PR won't conflict with #207.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yukukotani @ryanseddon