Add timeout option to uri requests #1382
Open
+92
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ryanheise,
This is a pull request to address #1119, it includes the following changes:
I realize there may be a need to implement the same functionality for all other platforms. I've just carried out the changes for Android as it's what I could test comfortably.
I added change notes and bumped the versions both just_audio and just_audio_platform_interface though I suppose just_audio_platform_interface would need to be published first followed by just_audio, if these changes are accepted ofcourse.
Note for local testing: Update just_audio_platform_interface/just_audio_web dependency in just_audio pubspec to point to local folder
Regards,
Cris