Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt SLURM engine for multi-node jobs #212

Merged
merged 9 commits into from
Nov 4, 2024
Merged

Adapt SLURM engine for multi-node jobs #212

merged 9 commits into from
Nov 4, 2024

Conversation

NeoLegends
Copy link
Member

  • Wrap calls into srun (better resource tracking according to internet, also required to start --ntasks > 1 at all)
  • Add support for log file linking when multiple SLURM tasks are involved

@NeoLegends NeoLegends added the enhancement New feature or request label Oct 24, 2024
@NeoLegends NeoLegends self-assigned this Oct 24, 2024
@NeoLegends NeoLegends requested a review from michelwi November 4, 2024 12:59
albertz
albertz approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@albertz albertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments, otherwise ok.

@NeoLegends NeoLegends merged commit d256f43 into master Nov 4, 2024
3 checks passed
@NeoLegends NeoLegends deleted the moritz-multi-node-slurm branch November 4, 2024 14:54
This was referenced Dec 3, 2024
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelwi michelwi michelwi approved these changes

@albertz albertz albertz approved these changes

@curufinwe curufinwe Awaiting requested review from curufinwe

@critias critias Awaiting requested review from critias

@JackTemaki JackTemaki Awaiting requested review from JackTemaki

@Atticus1806 Atticus1806 Awaiting requested review from Atticus1806

Assignees

@NeoLegends NeoLegends

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NeoLegends @albertz @michelwi