Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove nose #1664

Merged
merged 7 commits into from
Dec 11, 2024
Merged

tests: remove nose #1664

merged 7 commits into from
Dec 11, 2024

Conversation

NeoLegends
Copy link
Member

@NeoLegends NeoLegends commented Dec 11, 2024

AST search+replace is my friend. I do expect many tests to fail and then I gradually fix them until everything is green again.

Closes #1647

@NeoLegends NeoLegends self-assigned this Dec 11, 2024
@albertz
Copy link
Member

albertz commented Dec 11, 2024

Nice. Can you explain a bit more how you did the (automatic?) replacement?

@NeoLegends
Copy link
Member Author

NeoLegends commented Dec 11, 2024

Using https://ast-grep.github.io/, or respectively the VS Code plugin https://marketplace.visualstudio.com/items?itemName=ast-grep.ast-grep-vscode. It then becomes a regular search + replace (on master):
image

I actually just found this today, it's really cool stuff!

@NeoLegends NeoLegends marked this pull request as ready for review December 11, 2024 13:53
@NeoLegends NeoLegends requested review from albertz and a team as code owners December 11, 2024 13:53
@albertz albertz merged commit 4c6e245 into master Dec 11, 2024
64 checks passed
@albertz albertz deleted the moritz-remove-nose branch December 11, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove Nose dependency
2 participants