Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ComputeTSEJob #523

Merged
merged 6 commits into from
Jul 8, 2024
Merged

Add ComputeTSEJob #523

merged 6 commits into from
Jul 8, 2024

Conversation

SimBe195
Copy link
Contributor

@SimBe195 SimBe195 commented Jul 3, 2024

Adds a new ComputeTSEJob that can compute the TSE value of some alignment compared to a reference. The outputs of the job are the overall TSE value as well as detailed shift-counts of word-start and word-end frames as dicts and as histogram plots.

The job allows alignments with different amounts of subsampling and it's also possible to pass a function that specifies a seq-tag transformation to match up the alignment seq-tags with the reference seq-tags.

mm/alignment.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Marvin84 Marvin84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this job has been extensively tested, I think I do not have any further comments. Thanks for the integration. What I find very nice in the implementation is that it is agnostic to the label topology.

Copy link
Contributor

@JackTemaki JackTemaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the technical side, as I cannot comment on the algorithmic side, I will pass the responsibility of a second approval to someone else :)

mm/alignment.py Outdated Show resolved Hide resolved
mm/alignment.py Outdated Show resolved Hide resolved
mm/alignment.py Show resolved Hide resolved
mm/alignment.py Outdated Show resolved Hide resolved
mm/alignment.py Outdated Show resolved Hide resolved
@SimBe195 SimBe195 requested a review from Icemole July 4, 2024 14:50
@SimBe195
Copy link
Contributor Author

SimBe195 commented Jul 4, 2024

Thanks @Icemole, I incorporated your suggestions now.

mm/alignment.py Outdated Show resolved Hide resolved
mm/alignment.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Icemole Icemole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying my feedback!

@SimBe195 SimBe195 merged commit 394a9a9 into main Jul 8, 2024
4 checks passed
@SimBe195 SimBe195 deleted the ComputeTSEJob branch July 8, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants