-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ComputeTSEJob #523
Add ComputeTSEJob #523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this job has been extensively tested, I think I do not have any further comments. Thanks for the integration. What I find very nice in the implementation is that it is agnostic to the label topology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from the technical side, as I cannot comment on the algorithmic side, I will pass the responsibility of a second approval to someone else :)
Thanks @Icemole, I incorporated your suggestions now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for applying my feedback!
Adds a new
ComputeTSEJob
that can compute the TSE value of some alignment compared to a reference. The outputs of the job are the overall TSE value as well as detailed shift-counts of word-start and word-end frames as dicts and as histogram plots.The job allows alignments with different amounts of subsampling and it's also possible to pass a function that specifies a seq-tag transformation to match up the alignment seq-tags with the reference seq-tags.