Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alias prefix to filterbank features #489

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

Marvin84
Copy link
Contributor

@Marvin84 Marvin84 commented Mar 26, 2024

Other feature extraction functions of the system have explicit prefix parameter, which this PR adds also to the filterbanks

Copy link
Contributor

@vieting vieting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR's title could be more descriptive of what is done here, otherwise ok.

@Marvin84
Copy link
Contributor Author

The PR's title could be more descriptive of what is done here, otherwise ok.

updated

@JackTemaki JackTemaki changed the title to be consistent with other similar functions Add alias prefix to filterbank features Mar 26, 2024
@JackTemaki
Copy link
Contributor

@Marvin84 please do not do pull requests from personal fork branches, but always from branches within i6_core

@JackTemaki JackTemaki merged commit ff86467 into rwth-i6:main Mar 26, 2024
3 of 4 checks passed
@michelwi
Copy link
Contributor

@JackTemaki please do not merge a PR from a fork without confirming with us/me. I will manually trigger a pipeline now to check if this breaks any important recipes.

@JackTemaki
Copy link
Contributor

@JackTemaki please do not merge a PR from a fork without confirming with us/me. I will manually trigger a pipeline now to check if this breaks any important recipes.

I was confident enough about this one... but you are right this is against protocol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants