Caching behavior in ConcatenateJob #481
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ConcatenateJob
has currently hard-coded caching behavior.In a case where I wanted to concatenate feature cache bundle files, this is suboptimal because caching the bundle (I think it's determined via the ending
".bundle"
) means caching all files inside that. That (a) takes unnecessarily long because we don't need to cache the content files and (b) - more importantly - is also wrong because the concatenated output file will contain the cached paths starting with/var/tmp/
.I used
Path
objects and setcached=False
. The proposed change results in the intended behavior. Should we keep the compatibility for string inputs?Also, I refactored the init function a bit.