Change BlissFfmpegJob threading #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- force ffmpeg to use 1 thread for input and output processing each - set higher number of default cpu cores - remote some tk.uncached_path calls
JackTemaki
requested review from
albertz,
curufinwe,
michelwi,
vieting and
Atticus1806
michelwi
reviewed
Jan 18, 2024
michelwi
approved these changes
Jan 18, 2024
Atticus1806
approved these changes
Jan 22, 2024
christophmluscher
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working in a different cluster environment I found out that the job was spawing way more threads than it should, leading to conflicts with the cluster settings and also having an impact on efficiency.
These changes force ffmpeg to use only one thread for the input processing and one thread for the output processing. The pool size is adjusted accordingly.
I also increased the number of default cores, but this is debatable. The extra thread for the python process might not be strictly necessary for maximum performance (I did not test for that), but the cluster environment kills jobs that uses more threads than requested, and with this settings it worked.
From commit message