Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FairseqHydraTrainingJob: fix mutable default arg #472

Merged
merged 1 commit into from
Jan 4, 2024
Merged

FairseqHydraTrainingJob: fix mutable default arg #472

merged 1 commit into from
Jan 4, 2024

Conversation

vieting
Copy link
Contributor

@vieting vieting commented Jan 4, 2024

Fix #470.

@vieting vieting requested review from michelwi and Judyxujj January 4, 2024 09:27
@vieting vieting mentioned this pull request Jan 4, 2024
Closed
@vieting vieting merged commit 74d328f into main Jan 4, 2024
4 checks passed
@vieting vieting deleted the peter_fairseq_rqmt branch January 4, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atticus1806 Atticus1806 Atticus1806 approved these changes

@michelwi michelwi michelwi approved these changes

@Judyxujj Judyxujj Awaiting requested review from Judyxujj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FairseqHydraTrainingJob has mutable default argument
3 participants
@vieting @michelwi @Atticus1806