reviewer comments

rwth-i6 · Mar 26, 2024 · d0c3865 · d0c3865
1 parent 51d5a63
commit d0c3865
Showing 1 changed file with 2 additions and 9 deletions.
diff --git a/lm/srilm.py b/lm/srilm.py
@@ -117,7 +117,7 @@ def __init__(
         self.counts = counts
         self.vocab = vocab
         self.count_exe = count_exe
-        self.discount_args = extra_discount_args
+        self.discount_args = extra_discount_args or []
 
         self.out_discounts = self.output_path("discounts", cached=True)
 
@@ -138,18 +138,11 @@ def create_files(self):
             f"{self.count_exe.get_path()} \\\n",
             f"  -order {self.ngram_order} \\\n",
             f"  -vocab {self.vocab.get_cached_path()} \\\n",
-        ]
-
-        cmd += [
             f"  -kn discounts",
             f"  -read {self.counts.get_cached_path()} \\\n",
+            f"  {' '.join(self.discount_args)} -memuse\n",
         ]
 
-        if self.discount_args is not None:
-            cmd += [
-                f"  {' '.join(self.discount_args)} -memuse\n",
-            ]
-
         create_executable("run.sh", cmd)
 
     def run(self):