Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite NBT tag recursion in getUpdateTag(). Fixes #101. #104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maruohon
Copy link
Contributor

@maruohon maruohon commented Feb 7, 2017

I don't really know what the purpose of the TileMovingBase.desc tag is, and when it is supposed to be populated and why... so this fix might break stuff. But at least the current code causes an infinite NBT tag recursion when the getUpdateTag() calls writeToNBT() and gives it the desc tag to write to, and it then writes the desc tag inside itself.... This causes the clients to disconnect when they try to read that infinitely recursive tag and also causes StackOverflow fun on the server whenever something is moved on a dedicated server.

@Moke3
Copy link

Moke3 commented Apr 7, 2017

Hey man, do you know if i could download this in a .jar file as a sort of patched FunkyLocomotion? I've tried some different ways without success since i don't do this normally, but i really enjoy the mod and want it fixed. Having a hard time to get it into both my Server and my own FTB laucher

Cheers

@maruohon
Copy link
Contributor Author

maruohon commented Apr 7, 2017

@Moke3 Do you use reddit or Discord? I can link you the build I have been using on my testing server (which also has some other small fixes), but I don't want to link that publicly as I assume I don't have the permission to really redistribute it. I'm on Discord as masa#5718, and I also have my own channel on the MMD server, or on reddit as /u/masa_ so you can message me on either of those and I'll give you the link to my build.

Or alternatively, if you want to build it yourself, clone or download the zip from here: https://github.com/maruohon/FunkyLocomotion/tree/masa ie. make sure you get the masa branch if you are on 1.10.2. Then, to build it:

  • Make sure you have the JDK (Java Development Kit) installed (on your computer where you are going to run the build command), and not just the JRE (Java Runtime Environment) like normal users would have. You can download it from here: http://www.oracle.com/technetwork/java/javase/downloads/index.html
  • You need to clone or download the FL repository from my fork, and make sure you get the correct branch that has my fix, I'd recommend getting the masa branch. Assuming you don't have git or don't know how to use it, the simplest way is to go here: https://github.com/maruohon/FunkyLocomotion/tree/masa and click the green "Clone or download" button on the right.
  • Extract it somewhere
  • Open a command prompt into that directory (where the build.gradle file is, among other things). Assuming you are on Windows, then you can go to that directory in explorer, hold shift and right click (not on any file) and select Open command window here
  • Run the command ./gradlew build
  • If that succeeds, you should end up with a new FL jar inside the build/libs/ directory. Copy the one that does not have deobf in its name, into the mods/ directory on whichever minecraft instance you are running from.

@deadspidervenom
Copy link

@maruohon hey mind sending me the 1.10.2 fix for funky locomotion, my discord is deadspidervenom#8644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants