Fix infinite NBT tag recursion in getUpdateTag(). Fixes #101. #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't really know what the purpose of the TileMovingBase.desc tag is, and when it is supposed to be populated and why... so this fix might break stuff. But at least the current code causes an infinite NBT tag recursion when the getUpdateTag() calls writeToNBT() and gives it the desc tag to write to, and it then writes the desc tag inside itself.... This causes the clients to disconnect when they try to read that infinitely recursive tag and also causes StackOverflow fun on the server whenever something is moved on a dedicated server.