Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix import errors for builds w/o optional pem feature #162

Merged
merged 5 commits into from
Sep 28, 2023

Conversation

cpu
Copy link
Member

@cpu cpu commented Sep 27, 2023

In 0.11.2 the src/crl.rs and src/key_pair.rs modules were unconditionally importing crate::ENCODE_CONFIG, but this is only present when building with the optional pem feature. Additionally the crate example binaries, doc examples, and unit tests were often implicitly depending on pem, breaking compilation with --no-default-features.

This branch adds the correct import feature cfg gates, adds CI coverage for --no-default-features testing and clippy, fixes all of the various implicit pem dependencies, and updates CHANGELOG.md for a point release to include the fixes.

Resolves #161

@cpu cpu self-assigned this Sep 27, 2023
@cpu cpu marked this pull request as draft September 27, 2023 14:56
@cpu cpu force-pushed the cpu-fix-no-default-feats-rebase branch 2 times, most recently from 6fa2855 to 31a3c46 Compare September 27, 2023 16:09
src/crl.rs Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
examples/rsa-irc-openssl.rs Outdated Show resolved Hide resolved
@cpu cpu marked this pull request as ready for review September 27, 2023 16:31
examples/rsa-irc-openssl.rs Outdated Show resolved Hide resolved
@cpu cpu force-pushed the cpu-fix-no-default-feats-rebase branch from 31a3c46 to a9b782e Compare September 28, 2023 12:29
@cpu cpu added this pull request to the merge queue Sep 28, 2023
Merged via the queue into rustls:main with commit a15d59e Sep 28, 2023
13 checks passed
@cpu cpu deleted the cpu-fix-no-default-feats-rebase branch September 28, 2023 12:31
@cpu
Copy link
Member Author

cpu commented Sep 28, 2023

ugh I think the merge queue isn't set up with the right branch protection rules. It merged before CI completed. I'll keep an eye on the actions run to make sure nothing broke.

@cpu cpu mentioned this pull request Sep 28, 2023
@cpu
Copy link
Member Author

cpu commented Sep 28, 2023

I think the merge queue isn't set up with the right branch protection rules.

I've updated the branch protection rules to require all CI jobs except the coverage one. Administrative merge override still possible if circumstances demand it.

I'll keep an eye on the actions run to make sure nothing broke.

Edit: and it built all green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.11.2 build error w/o pem feature.
3 participants