-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix import errors for builds w/o optional pem feature #162
Conversation
6fa2855
to
31a3c46
Compare
31a3c46
to
a9b782e
Compare
ugh I think the merge queue isn't set up with the right branch protection rules. It merged before CI completed. I'll keep an eye on the actions run to make sure nothing broke. |
I've updated the branch protection rules to require all CI jobs except the coverage one. Administrative merge override still possible if circumstances demand it.
Edit: and it built all green. |
In 0.11.2 the
src/crl.rs
andsrc/key_pair.rs
modules were unconditionally importingcrate::ENCODE_CONFIG
, but this is only present when building with the optionalpem
feature. Additionally the crate example binaries, doc examples, and unit tests were often implicitly depending onpem
, breaking compilation with--no-default-features
.This branch adds the correct import feature cfg gates, adds CI coverage for
--no-default-features
testing and clippy, fixes all of the various implicitpem
dependencies, and updatesCHANGELOG.md
for a point release to include the fixes.Resolves #161