macOS: don't implicitly activate background apps #3997
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunixbochs
force-pushed
the
fix-mac-background-activation
branch
from
f2eba4c
to
c3d3ede
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a weird interaction with background-only tray applications on macOS.
If you build an event loop with
EventLoopBuilderExtMacOSand set it to prohibited activation:winit will still call
app.activateIgnoringOtherAppson startup.This usually has no effect, because winit won't be able to activate the app.
But it turns out winit can activate the app while the tray menu is open, so if you open the tray menu while the app is launching, macOS will close the menu and give focus to your background app.
The resulting experience is: user launches your app, opens the tray menu, then the menu quickly closes itself.
(Just adding
.with_activate_ignoring_other_apps(false)is not enough to fully work around this, because it's possible to have no application active at this time, in which case your background app will still be activated and the menu will be closed)