macOS: set activation policy by default if app does not have a bundle identifier #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchibisov
reviewed
Oct 23, 2024
Co-authored-by: Kirill Chibisov <[email protected]>
|
(As the author of #3920 that caused this) Thanks for doing this so quickly! Makes sense to me. |
madsmtm
approved these changes
Oct 25, 2024
Comment on lines
+121
to
+123
| let is_bundle = | ||
| unsafe { NSRunningApplication::currentApplication().bundleIdentifier().is_some() }; | ||
| if !is_bundle { |
There was a problem hiding this comment.
Please add a comment here, perhaps linking to #3958
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelogmodule if knowledge of this change could be valuable to usersThis is an alternative fix for #3958 which makes the fix within winit itself rather than in the
windowexample like #3959. I think something like this is probably the better fix as it means that users don't all have to set the activation policy manually if they want keyboard support.