Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux/Android: Document /dev/random polling considerations. #452

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Linux/Android: Document /dev/random polling considerations. #452

merged 1 commit into from
Jun 4, 2024

Conversation

briansmith
Copy link
Contributor

See the added comment for details.

This was referenced Jun 4, 2024
Closed
Closed
josephlr
josephlr approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this comment. The logic behind this is certainly nontrivial.

Could we just have this comment be the function-level comment? The existing comment:

// Succeeds once /dev/urandom is safe to read from

Isn't very good and this could replace it.

@briansmith
Copy link
Contributor Author

Could we just have this comment be the function-level comment? The existing comment:

Done.

@josephlr josephlr merged commit a4b1f2f into rust-random:master Jun 4, 2024
52 checks passed
@briansmith briansmith mentioned this pull request Jun 6, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephlr josephlr josephlr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briansmith @josephlr