Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logistic Regression: Binary class labels getter #325

Merged
merged 1 commit into from
Dec 24, 2023

Conversation

DGPardo
Copy link
Contributor

@DGPardo DGPardo commented Dec 22, 2023

Expose a reference to the mapping from the ground truth data label to the assigned binary label used in the logistic regression model.

This goes in line with the output provided by MultiFittedLogisticRegression that has a method to access classes

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0d8b62a) 36.73% compared to head (cf15ccd) 36.71%.

Files Patch % Lines
algorithms/linfa-logistic/src/lib.rs 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
- Coverage   36.73%   36.71%   -0.02%     
==========================================
  Files          94       94              
  Lines        6240     6242       +2     
==========================================
  Hits         2292     2292              
- Misses       3948     3950       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@quietlychris quietlychris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these methods/structs are being made public, can you add doc comments for each? Otherwise this looks good, although you may need to rebase onto master. The CI isn't passing right now bc of what looks like a Windows linking issue, but I'll don't think that should gate this being merged.

… the assigned binary label used in the logistic regression model
@DGPardo
Copy link
Contributor Author

DGPardo commented Dec 24, 2023

Thanks for your review @quietlychris
I think I have addressed your requests, otherwise please let me know

@quietlychris quietlychris merged commit d495562 into rust-ml:master Dec 24, 2023
20 checks passed
@quietlychris
Copy link
Member

Looks good, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants