Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clustering] Derive {Des,S}erialize for all public items #324

Merged
merged 1 commit into from
Nov 23, 2023
Merged

[clustering] Derive {Des,S}erialize for all public items #324

merged 1 commit into from
Nov 23, 2023

Conversation

cyqsimon
Copy link
Contributor

It doesn't hurt to have them, and it's really annoying when you need it but it's missing.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (083fc9a) 36.75% compared to head (07c7bca) 36.76%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #324   +/-   ##
=======================================
  Coverage   36.75%   36.76%           
=======================================
  Files          94       94           
  Lines        6241     6240    -1     
=======================================
  Hits         2294     2294           
+ Misses       3947     3946    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@quietlychris quietlychris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you!

@quietlychris quietlychris merged commit 00e59f6 into rust-ml:master Nov 23, 2023
20 checks passed
@cyqsimon cyqsimon deleted the derive-serde branch November 24, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants