replace map with mapv_into

rust-ml · May 10, 2024 · 4df156f · 4df156f
1 parent 74b7865
commit 4df156f
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/metrics_regression.rs b/src/metrics_regression.rs
@@ -23,16 +23,16 @@ pub trait SingleTargetRegression<F: Float, T: AsSingleTargets<Elem = F>>:
         let max_error = self
             .as_single_targets()
             .sub(&compare_to.as_single_targets())
-            .iter()
-            .map(|x| x.abs())
+            .mapv_into(|x| x.abs())
+            .into_iter()
             .fold(F::neg_infinity(), F::max);
         Ok(max_error)
     }
     /// Mean error between two continuous variables
     fn mean_absolute_error(&self, compare_to: &T) -> Result<F> {
         self.as_single_targets()
             .sub(&compare_to.as_single_targets())
-            .mapv(|x| x.abs())
+            .mapv_into(|x| x.abs())
             .mean()
             .ok_or(Error::NotEnoughSamples)
     }
@@ -41,7 +41,7 @@ pub trait SingleTargetRegression<F: Float, T: AsSingleTargets<Elem = F>>:
     fn mean_squared_error(&self, compare_to: &T) -> Result<F> {
         self.as_single_targets()
             .sub(&compare_to.as_single_targets())
-            .mapv(|x| x * x)
+            .mapv_into(|x| x * x)
             .mean()
             .ok_or(Error::NotEnoughSamples)
     }