Avoid two allocations #6326
Merged
Avoid two allocations #6326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytmimi
reviewed
Sep 16, 2024
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| use std::{borrow::Cow, iter}; | |||
|
|
|||
| use itertools::{MultiPeek, multipeek}; | |||
| use itertools::{Itertools as _, MultiPeek, multipeek}; | |||
There was a problem hiding this comment.
Could you explain why you're brining Itertools into scope?
There was a problem hiding this comment.
It is used for the Itertools::join on line 1077.
ytmimi
reviewed
Sep 16, 2024
Comment on lines
-1078
to
+1077
| .collect(); | ||
| lines.join(&format!("\n{}", offset.to_string(config))) | ||
| .join(&format!("\n{}", offset.to_string(config))) |
There was a problem hiding this comment.
Okay, so just want to make sure I'm understanding this correctly. This avoids allocating the Vec<&str> and directly allocates into a String?
ytmimi
force-pushed
the
avoid-allocs-2
branch
from
f7205e7 to
96dbcc3
Compare
ytmimi
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.