Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl rewrite_result for ast nodes in types.rs #6220

Merged
merged 2 commits into from
Jul 6, 2024

Conversation

ding-young
Copy link
Contributor

@ding-young ding-young commented Jun 29, 2024

Tracked by #6206

Description

  • SegmentParam
  • PreciseCapturingArg - will work on further pr for refactoring rewrite_path
  • ast::AssocConstraint - will work on further pr with rewrite_generic_args
  • ast::AssocConstraintKind
  • ast::WherePredicate - will work on further pr with rewrite_assign_rhs
  • ast::GenericArg
  • ast::AnonConst - directly calls format_expr, so better delay until almost every ast node that corresponds to ExprKind has rewrite_result implementation
  • ast::Lifetime - does it worth replacing at this point? it just wraps String with Some
  • ast::GenericBound
  • ast::GenericBounds
  • ast::GenericParam
  • ast::PolyTraitRef - will work with TraitRef
  • ast::TraitRef - calls rewrite_path. will work on further pr for refactoring rewrite_path
  • ast:Ty

@ytmimi ytmimi added the GSoC Google Summer of Code label Jul 1, 2024
@ding-young ding-young changed the title [WIP] Impl rewrite_result for ast nodes in types.rs Impl rewrite_result for ast nodes in types.rs Jul 5, 2024
@ding-young ding-young marked this pull request as ready for review July 5, 2024 16:18
Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the code changes seem very straightforward to me. I just left one nit pick, but I'm also fine leaving the code as is

src/types.rs Outdated Show resolved Hide resolved
@ytmimi ytmimi merged commit eed7e23 into rust-lang:master Jul 6, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Google Summer of Code pr-ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants