Implement rewrite_result for AST nodes #6201
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Since current
rewrite
method cannot track the context , this pr plans to implementrewrite_result
method that returns Result. I will replacerewrite
withrewrite_result
in further pr.Detail
Added a default implementation of the
rewrite_result
method, which calls the existing rewrite method and transforms theOption
into aResult
with a default error kind. Additionally, I implemented therewrite_result
method for theChain
andast::Local
types by copying the body of their respective rewrite functions and replacing some of theOption
handling logic with appropriate error handling.TODO & Question