Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Rust code #188

Merged
merged 13 commits into from
Dec 13, 2024
Merged

Refactor the Rust code #188

merged 13 commits into from
Dec 13, 2024

Conversation

nikomatsakis
Copy link
Contributor

@nikomatsakis nikomatsakis commented Dec 13, 2024

The Rust code started small but it's gotten rather sprawling. This refactors into a number of crates and creates a cargo alias (cargo rpg) for interacting with them.

A couple of notable goals

  • the rust_project_goals library just defines common data structures and utilities, it's meant to be importable by others
  • the rust_project_goals_json library defines specifically the versioned API data structures
  • the LLM-related stuff is factored out so you don't have to build it unless you run the cargo rpg updates subcommand, as it takes a while

Goals

  • allow people to depend on rust_project_goals_json
  • shorten CI build times

@nikomatsakis nikomatsakis merged commit 49e65a6 into rust-lang:main Dec 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant