feat(ci): add llvm-cov to template ci #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshrotenberg
force-pushed
the
add-llvm-cov
branch
from
1e9197d
to
d7b75cb
Compare
move this into the raw block removed the upload section
joshrotenberg
force-pushed
the
add-llvm-cov
branch
from
d7b75cb
to
3627f4e
Compare
|
Thanks for this! How is the user supposed to use the lcov.info file? It would be nice to show the coverage percentage in the readme. This repo used coveralls for this. |
add coveralls action
joshrotenberg
force-pushed
the
add-llvm-cov
branch
from
68608eb
to
d6c58ef
Compare
👍
Good question. I just added the coveralls action with just the The output for the run is here: https://github.com/joshrotenberg/rust-template-llvm-cov-test/actions/runs/8530312705/job/23367853431
Where is this? I don't see it. |
It was here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the cut/paste llvm-cov job from the docs.
I tested this by creating a project with the template and put it here: https://github.com/joshrotenberg/rust-template-llvm-cov-test
I removed the call to upload the coverage file in the workflow because it requires the token in secrets, which means the workflow fails by default, which seems bad, but I'm open to suggestions.
Fixes #44