Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated nix dependency version to 0.14 #14

Merged
merged 1 commit into from
May 29, 2019

Conversation

drinkdhmo
Copy link
Contributor

This fixes the compilation error on a Raspberry Pi Zero W (and presumably other armhf7 devices).

@drinkdhmo
Copy link
Contributor Author

drinkdhmo commented May 26, 2019

Attempts to resolve #13. See also this effort to update all packages dependent on nix.

@drinkdhmo
Copy link
Contributor Author

nix::poll::EventFlags was renamed to nix::poll::PollFlags in upstream. See this pull request.

@posborne posborne self-requested a review May 29, 2019 06:19
@posborne
Copy link
Member

Hi @drinkdhmo, thanks for the change. Would you mind confirming that this is working and clean up the branch to remove the merge commit. Probably just squash all this down to a single commit.

P.S. Repo just moved to rust-embedded org.

@posborne posborne mentioned this pull request May 29, 2019
@mathk mathk added the S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label May 29, 2019
@drinkdhmo
Copy link
Contributor Author

Can confirm, this compiles and gpio works on a RPi zero W, with kernel 4.19.42+.

@posborne
Copy link
Member

Excellent, thanks @drinkdhmo. Going to try bors but I think it isn't quite fully setup.

@posborne
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request May 29, 2019
14: Updated nix dependency version to 0.14 r=posborne a=drinkdhmo

This fixes the compilation error on a Raspberry Pi Zero W (and presumably other armhf7 devices).

Co-authored-by: Craig Bidstrup <[email protected]>
@posborne posborne merged commit 8062b63 into rust-embedded:master May 29, 2019
@bors
Copy link
Contributor

bors bot commented May 29, 2019

Timed out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants