Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: select probe for on-target test #534

Merged
merged 2 commits into from
Jun 30, 2024
Merged

CI: select probe for on-target test #534

merged 2 commits into from
Jun 30, 2024

Conversation

newAM
Copy link
Member

@newAM newAM commented May 21, 2024

No description provided.

@newAM newAM marked this pull request as ready for review May 21, 2024 14:39
@newAM newAM requested a review from a team as a code owner May 21, 2024 14:39
@newAM newAM enabled auto-merge May 21, 2024 23:47
adamgreig
adamgreig previously approved these changes Jun 30, 2024
View reviewed changes
@newAM newAM added this pull request to the merge queue Jun 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 30, 2024
@adamgreig
Copy link
Member

Ugh, it looks like a syn minor version bump increased their MSRV to 1.61, beyond our current 1.60...

@newAM
Copy link
Member Author

newAM commented Jun 30, 2024

I attempted to pin syn, with something similar to:

[dependencies.syn]
version = ">=2.0.0,<2.0.53"
optional = true

[features]
serde = ["dep:serde", "dep:syn"]

However our MSRV doesn't support dep: either.

I could pin our lockfile in CI, but that doesn't solve the problem for downstream consumers.

I think the easiest way out for now is an MSRV bump?

@adamgreig
Copy link
Member

Yep, I think go ahead with an MSRV bump in this PR.

@newAM
MSRV: 1.60 -> 1.61
6fef9cc 
This aligns with the MSRV for syn
@newAM newAM enabled auto-merge June 30, 2024 19:45
@newAM newAM added this pull request to the merge queue Jun 30, 2024
Merged via the queue into rust-embedded:master with commit 2fe5473 Jun 30, 2024
14 checks passed
@newAM newAM deleted the fix-on-target branch June 30, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newAM @adamgreig