This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change. The
tags
attribute will change from string-type toset-of-string type. Users will need to make the following syntactic
change to their Terraform configuration files:
This commit includes a schema migration for existing user state.
The Pingdom API returns tag elements in an unpredictable order.
Ordering for this type is not documented in the Pingdom API spec.
Current plugin behaviour often leads to spurious diffs against state.
https://www.pingdom.com/api/2.1/#MethodGet+Check+List
Notionally, tags should be considered to be sets in the Pingdom data
model. It does not make much practical sense for us to enforce strict
ordering on them. Any implied ordering is likely an inadvertent
side-effect of JSON's lack of an unordered set type.
This change will hash tag names using the FNV-1a alternate algorithm.
(Tag names are the only labels that users see in the Pingdom UI and API.
Pingdom do not expose tag IDs in their API.)
http://www.isthe.com/chongo/tech/comp/fnv/index.html#FNV-1a
As far as I know, this algorithm is a good fit for set element hash
computation: it is said to be fast, said to provide reasonably good
dispersion, and is a part of the Go standard library.