Add a progress indicator for RV-Predict. #755
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run the rv-predict tool on some trace that takes a long time, e.g. one generated by |
|
On Thu, Jun 29, 2017 at 10:00:41AM -0700, virgil-serbanuta wrote:
run the rv-predict tool on some trace that takes a long time, e.g. one generated by
raceless-signal -sv
You can try various window sizes, e.g. 300 and 2000.
Thanks.
I get this output,
dyoung@rvwork-1:~/share/examples/rv-predict-c/c11$ !rvpx
rvpx ./raceless-signal -sv
[RV-Predict] No races found.0. Current input tasks: 100%. Time left: 0s..
Then the analysis seems to hang (the JVM keeps running).
Dave
…--
David Young
[email protected] Urbana, IL (217) 721-9981
|
|
On Thu, Jun 29, 2017 at 12:17:50PM -0500, David Young wrote:
On Thu, Jun 29, 2017 at 10:00:41AM -0700, virgil-serbanuta wrote:
> run the rv-predict tool on some trace that takes a long time, e.g. one generated by
> raceless-signal -sv
> You can try various window sizes, e.g. 300 and 2000.
Thanks.
I get this output,
***@***.***:~/share/examples/rv-predict-c/c11$ !rvpx
rvpx ./raceless-signal -sv
[RV-Predict] No races found.0. Current input tasks: 100%. Time left: 0s..
Then the analysis seems to hang (the JVM keeps running).
Sorry, it doesn't hang. But it kept running, and then it printed this
again:
[RV-Predict] No races found.0. Current input tasks: 100%. Time left: 0s..
Hmm, there may be something funny going on in my environment.
Dave
…--
David Young
[email protected] Urbana, IL (217) 721-9981
|
|
This progress indicator is a console one. I think that the rvpa script is redirecting the output, so you won't get anything on the console. Would it be fine to not block the output (either the stdout, or stderr)? Or let the progress output go through the rvpa/x filtering? Otherwise, the only option is a GUI, but that wouldn't work through ssh. |
|
On Thu, Jun 29, 2017 at 11:06:21AM -0700, virgil-serbanuta wrote:
This progress indicator is a console one. I think that the rvpa script is redirecting the output, so you won't get anything on the console.
Silly me. You're right.
This is going to require more thought.
One thing that I'd like to do is make the rvpsymbolize process simpler
and faster. Maybe now is the time. But it may have to wait until after
the release.
Dave
…--
David Young
[email protected] Urbana, IL (217) 721-9981
|
|
I have added your commit as-is. Clearing the line is more complicated, but I could do that in a follow-up pull request if you think it's important. |
does not intermingle with another. Follow the last progress indication with a newline, so that the first line of the first race report (or the "No races found." indication) does not intermingle with the text of the last indication. Insert a newline between the last progress indication and the race reports. (It would also look nice if we just erased the last progress indication, instead.) My code changes are kind of hackish, sorry. Please feel free to handle this another way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes some unrelated warnings in the files I touched.