close default kcfg minimization 4 cse #885
Draft
+145,895
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,5 @@ | |||
| AssertTest.test_assert_false() | |||
There was a problem hiding this comment.
What is this file used for? I think foundry-dependency-* stores the test function names for CSE tests.
Stevengre
commented
Nov 19, 2024
| @@ -477,7 +477,7 @@ def create_kcfg_explore() -> KCFGExplore: | |||
| if progress is not None and task is not None: | |||
| progress.update(task, advance=1, status='Finished') | |||
|
|
|||
| if options.minimize_proofs or options.config_type == ConfigType.SUMMARY_CONFIG: | |||
| if options.minimize_proofs: | |||
There was a problem hiding this comment.
Close default minimize_proofs for SUMMARY_CONFIG.
Stevengre
commented
Nov 19, 2024
| @@ -23,3 +23,4 @@ InterfaceTagTest.testInterface() | |||
| ConstructorTest.init | |||
| ImportedContract.init | |||
| StaticCallContract.set(uint256) | |||
| MergeKCFGTest.test_branch_merge(uint256,uint256,bool) | |||
There was a problem hiding this comment.
introduce a new test for CSE.
Stevengre
commented
Nov 20, 2024
Comment on lines
+55
to
+68
| │ k: #execute ~> #return 128 32 ~> #pc [ STATICCALL ] ~> #execute ~> CONTINUATION:K | ||
| │ pc: 0 | ||
| │ callDepth: 1 | ||
| │ statusCode: STATUSCODE:StatusCode | ||
| │ src: test/nested/SimpleNested.t.sol:7:11 | ||
| │ method: src%ArithmeticContract.add(uint256,uint256) | ||
| │ | ||
| │ (1 step) | ||
| ├─ 15 (split) | ||
| │ k: JUMPI 570 bool2Word ( KV0_x:Int <=Int ( maxUInt256 -Int KV1_y:Int ) ) ~> #pc [ J ... | ||
| │ pc: 562 | ||
| │ callDepth: 1 | ||
| │ statusCode: STATUSCODE:StatusCode | ||
| │ method: src%ArithmeticContract.add(uint256,uint256) |
Stevengre
commented
Nov 20, 2024
| 'max_iterations': 100, | ||
| 'bug_report': bug_report, | ||
| 'cse': True, | ||
| 'minimize_proofs': False, |
There was a problem hiding this comment.
CSE CI test without minimization
Stevengre
commented
Nov 20, 2024
| ┃ │ statusCode: STATUSCODE:StatusCode | ||
| ┃ │ method: src%ArithmeticContract.add(uint256,uint256) | ||
| ┃ │ | ||
| ┃ │ (3 steps) |
There was a problem hiding this comment.
Used the summary!
Stevengre
commented
Nov 20, 2024
| ┃ │ src: test/nested/SimpleNested.t.sol:7:11 | ||
| ┃ │ method: src%ArithmeticContract.add(uint256,uint256) | ||
| ┃ │ | ||
| ┃ │ (1 step) |
There was a problem hiding this comment.
Used the summary.
Stevengre
commented
Nov 20, 2024
| ┃ ┃ │ statusCode: EVMC_SUCCESS | ||
| ┃ ┃ │ method: src%ArithmeticContract.add(uint256,uint256) | ||
| ┃ ┃ │ | ||
| ┃ ┃ │ (3 steps) |
There was a problem hiding this comment.
Used the summary.
Stevengre
commented
Nov 20, 2024
| ┃ │ statusCode: EVMC_SUCCESS | ||
| ┃ │ method: src%ArithmeticContract.add(uint256,uint256) | ||
| ┃ │ | ||
| ┃ │ (3 steps) |
There was a problem hiding this comment.
Used the summary.
Stevengre
commented
Nov 20, 2024
| │ statusCode: STATUSCODE:StatusCode | ||
| │ method: src%ArithmeticContract.add(uint256,uint256) | ||
| │ | ||
| │ (3 steps) |
There was a problem hiding this comment.
Used the summary.
Stevengre
commented
Nov 20, 2024
| │ src: test/nested/SimpleNested.t.sol:7:11 | ||
| │ method: src%ArithmeticContract.add_sub_external(uint256,uint256,uint256) | ||
| │ | ||
| │ (3 steps) |
There was a problem hiding this comment.
Used the summary!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, the
--cseoption don't provide more functionality more than(1) generating the summary rules from KCFG Edges of the external function;
(2) using these rules to reducing the rewriting steps for the functions / tests that calls them.
Some activities to achieve this:
--cse;