Handle list random access patterns in frontend #4634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add tests to |
ehildenb
reviewed
Sep 13, 2024
Comment on lines
+1
to
+11
| module TEST | ||
| imports LIST | ||
| imports INT | ||
|
|
||
| configuration <k> $PGM:K </k> <list> ListItem(0) ListItem(1) ListItem(2) </list> | ||
|
|
||
| syntax KItem ::= l(Int, Int) | ||
|
|
||
| rule <k> l(I, J) => .K ...</k> | ||
| <list> _ [ I <- J ] </list> | ||
| endmodule |
There was a problem hiding this comment.
Can we add a test l(5, 2) or the like? Something out of range?
|
@Scott-Guest will have to comment on the frontend code, but the tests look good, and the feature makes sense. |
Scott-Guest
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
L [ I <- X ]syntax on the LHS of rules, which allows you to pattern match on an arbitrary element of a list.The code is not fully polished; it is not integrated with configuration abstraction or cell collections. It is not likely to be further improved upon presently because the code it was intended to support ended up not proving worth merging. However, it is broadly useful functionality (along with the accompanying LLVM backend PR) and thus ought to be merged.